fix: still setup for user when setting up root path with children#57910
Merged
icewind1991 merged 6 commits intomasterfrom Feb 4, 2026
Merged
fix: still setup for user when setting up root path with children#57910icewind1991 merged 6 commits intomasterfrom
icewind1991 merged 6 commits intomasterfrom
Conversation
icewind1991
requested review from
come-nc,
leftybournes,
nfebe and
sorbaugh
and removed request for
a team
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Jan 29, 2026
…ren" Signed-off-by: Joas Schilling <coding@schilljs.com>
icewind1991
force-pushed
the
setup-root-path-children
branch
2 times, most recently
from
5f63e56 to
61db338
Compare
nickvergessen
approved these changes
Jan 29, 2026
artonge
approved these changes
Jan 29, 2026
icewind1991
force-pushed
the
setup-root-path-children
branch
from
61db338 to
75fe4c9
Compare
Member
Author
|
Sharding failures unrelated: #57915 |
Member
Failing integration test sounds related and seems still not fixed? |
icewind1991
force-pushed
the
setup-root-path-children
branch
from
75fe4c9 to
502567d
Compare
Member
Author
|
re-requesting reviews since 502567d is significant |
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Jan 31, 2026
…ren" Signed-off-by: Joas Schilling <coding@schilljs.com>
Merged
1 task
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Jan 31, 2026
…ren" Signed-off-by: Joas Schilling <coding@schilljs.com>
icewind1991
force-pushed
the
setup-root-path-children
branch
from
502567d to
5a9d352
Compare
icewind1991
force-pushed
the
setup-root-path-children
branch
3 times, most recently
from
cd4e5b8 to
bad72fc
Compare
icewind1991
force-pushed
the
setup-root-path-children
branch
from
bad72fc to
7982ff9
Compare
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Feb 3, 2026
…ren" Signed-off-by: Joas Schilling <coding@schilljs.com>
CarlSchwan
approved these changes
Feb 3, 2026
icewind1991
force-pushed
the
setup-root-path-children
branch
from
7982ff9 to
a7efbf4
Compare
Merged
artonge
reviewed
Feb 4, 2026
icewind1991
force-pushed
the
setup-root-path-children
branch
from
a7efbf4 to
810ff65
Compare
artonge
approved these changes
Feb 4, 2026
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Request for some extra comments so that it is easier to navigate the code later. Else, it seems good.
icewind1991
force-pushed
the
setup-root-path-children
branch
from
810ff65 to
4c3226f
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
setup-root-path-children
branch
from
4c3226f to
134fa67
Compare
Member
|
/backport to stable33 |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/57910/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 82d33b77 b51d3327 be2c26a7 72150d6d bea82ac6 134fa677
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/57910/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Contributor
|
@icewind1991 can you confirm whether we need to backport this one? Or are the fix already included in other PRs? |
Member
|
Should be in stable33 already with #58000 but lets wait for confirmation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #57829, when setting up with children, we still setup the full user, not just the root.